-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Sessions for Automatic Conversation History Management #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Sessions for Automatic Conversation History Management #752
Conversation
## Summary - Introduced `SessionMemory` and `SQLiteSessionMemory` classes for automatic conversation history management. - Updated `Agent` class to support session memory configuration. - Enhanced `Runner` class to handle input preparation and result saving with session memory. - Added example demonstrating session memory usage. - Implemented tests for session memory functionality. ## Testing - `make format` - `make lint` - `make mypy` - `make tests`
- Added a check to raise a ValueError if `session_id` is not provided when session memory is enabled. - Updated the `SessionMemory` class to use a Protocol instead of an abstract base class, simplifying the implementation. - Modified tests to ensure an exception is raised when attempting to run with memory enabled but no session_id is provided.
- Introduced a section on creating custom memory implementations following the `SessionMemory` protocol. - Added code examples demonstrating how to implement and use a custom memory class. - Highlighted the requirement for `session_id` when session memory is enabled, with examples illustrating correct usage.
- Updated the Runner class to ensure that when memory=True, a single instance of SQLiteSessionMemory is created and reused across runs. - Added a test to verify that the same memory instance is returned for multiple calls when memory is enabled. - Ensured the agent stores the memory instance for consistency.
- Updated README and example scripts to utilize `SQLiteSessionMemory` explicitly instead of using a boolean flag for memory. - Modified `RunConfig` to accept a memory instance directly, enhancing clarity and flexibility in session management. - Adjusted tests to reflect the new memory handling approach, ensuring consistent behavior across different configurations.
- Updated `mkdocs.yml` to include `session_memory.md` in the documentation. - Enhanced `index.md` to highlight the new **Session Memory** feature for automatic conversation history management. - Modified `running_agents.md` to include details about the `memory` and `session_id` parameters in `RunConfig`. - Added comprehensive documentation for session memory functionality in the new `session_memory.md` file, including usage examples and best practices.
- Included `memory.md` in the documentation by updating `mkdocs.yml`. - Corrected links in `session_memory.md` to point to the appropriate memory classes. - Created a new `memory.md` file detailing the `SessionMemory` and `SQLiteSessionMemory` classes.
…essions and messages - Updated the constructor to accept `sessions_table` and `messages_table` parameters, allowing users to specify custom table names. - Modified SQL queries to utilize the provided table names, ensuring flexibility in database schema. - Adjusted index creation and deletion queries to reflect the new table name parameters.
- Implemented the `pop_message` method to remove and return the most recent message from a session. - Updated the `SessionMemory` protocol to include the new method signature. - Enhanced documentation in `session_memory.md` with examples demonstrating the usage of `pop_message`. - Added tests to verify the functionality of `pop_message`, including edge cases for empty sessions and multiple sessions.
- Converted synchronous database operations in `get_messages`, `add_messages`, `pop_message`, and `clear_session` methods to asynchronous using `asyncio.to_thread`. - Improved performance and responsiveness of the session memory handling by allowing non-blocking database interactions.
- Implemented a check in the Runner class to raise a ValueError if a session_id is provided without enabling memory in the RunConfig. - Updated tests to verify that the appropriate exception is raised when session_id is used without memory.
- Updated README, session_memory.md, and example scripts to remove the use of RunConfig for session memory configuration, directly passing memory and session_id parameters to the Runner.run method. - Enhanced clarity in documentation regarding the requirement of session_id when memory is enabled. - Adjusted tests to reflect the new approach, ensuring consistent behavior across different configurations.
- Introduced a new method `_init_db_for_connection` to handle database schema initialization for a specific connection. - Updated the `_init_db` method to call the new method, improving clarity and separation of concerns. - Added a comment to indicate the initialization of the database schema for the connection.
- Deleted the `_init_db` method as database schema initialization is now handled in `_init_db_for_connection`. - This change simplifies the class structure and improves clarity in the database connection management.
- Introduced a shared connection for in-memory databases to avoid thread isolation, improving concurrency. - Implemented a locking mechanism for database operations to ensure thread safety, regardless of the database type. - Updated the `_get_connection`, `_add_messages_sync`, `_pop_message_sync`, and `_clear_session_sync` methods to utilize the new locking and connection management logic.
- Added logic to initialize the database schema for file databases during connection setup. - Ensured that the schema is only initialized once, improving efficiency and clarity in connection management.
- Enhanced the error handling mechanism in the Runner class to ensure that exceptions during setup result in a completion sentinel being placed in the event queue. - Streamlined the input preparation process by consolidating the logic for handling session memory and updating the streamed result. - Improved clarity and maintainability of the code by restructuring the try-except blocks and ensuring proper resource management for spans and traces.
- Removed unused imports and streamlined the import statements for clarity and maintainability. - This change enhances the readability of the test file by focusing on the necessary components.
…clarity - Replaced `SQLiteSessionMemory` with `SQLiteSession` in the codebase, streamlining session management. - Updated documentation and examples to reflect the new session handling approach, removing the need for `session_id` when using sessions. - Enhanced the `Session` protocol to better define session behavior and improve consistency across implementations. - Adjusted tests to ensure compatibility with the new session structure, maintaining functionality across various scenarios.
- Renamed `session_memory.md` to `session.md` for clarity and consistency. - Updated links in `running_agents.md` to reflect the new documentation filename. - Added comprehensive documentation for session memory functionality, including usage examples and API reference. - Removed references to `SessionMemory` and `SQLiteSessionMemory` from the codebase to streamline session management.
- Changed all references from "Session Memory" to "Sessions" in README, documentation, and example files for consistency. - Updated descriptions to clarify the functionality of Sessions in managing conversation history across agent runs.
- Renamed instances of "session.md" to "sessions.md" in mkdocs.yml and running_agents.md for consistency. - Added new sessions.md file detailing the functionality and usage of session memory in the Agents SDK, including examples and API reference.
- Updated the `get_messages` method in the `Session` and `SQLiteSession` classes to accept an optional `amount` parameter, allowing retrieval of the latest N messages or all messages if not specified. - Added a demonstration in `session_example.py` to showcase the new functionality for fetching the latest messages. - Implemented tests in `test_session.py` to verify the behavior of the `get_messages` method with various amounts, ensuring correct message retrieval.
…tions" and clarify session implementation details. Adjusted section headers and descriptions for consistency with recent documentation updates.
This seems like an obvious thing we should have. Maybe even extend this eventually to add simple rag to the session, that's more boilerplate I'd love not to have to build. 👍 ➕ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice PR, simple interface. Going to have a couple more people weigh in as well. @damon-openai @dkundel-openai wdyt?
|
||
|
||
@runtime_checkable | ||
class Session(Protocol): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, I prefer to use ABC
instead, because it is better checked by type checkers, its is more readable (because it's clear when reading the code that the implementation is for a the interface). Also, isinstance checks are faster with ABC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also go with ABC if it were meant only for internal use. The advantage of using Protocol is third-party implementations of our Session interface don't need to depend on openai-agents. We could even offer both -- a Session
(Protocol) and SessionABC
, with the protocol as the primary interface since ABCs automatically satisfy matching Protocols.
""" | ||
... | ||
|
||
async def pop_message(self) -> TResponseInputItem | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the usecase for popping messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful for making edits to the last user message or generating a new assistant response to the last user message.
I like the overall concept and design. Only concern on my side would be confusion if someone passes both a session and an array of inputs (as opposed to just a string like in the examples). |
That's an excellent point @dkundel-openai. I think it's better to raise an exception if a user tries passing both a list and a session. It would be confusing whether the list input should be appended to the existing session or replace it entirely. I'd rather be forced to choose between the two as a user. |
- Updated the `get_messages` method in the `Session` and `SQLiteSession` classes to use 'count' instead of 'amount' for clarity. - Adjusted the corresponding example in `session_example.py` to reflect this change. - Modified tests in `test_session.py` to ensure they reference the new 'count' parameter.
…on memory functionality. This cleanup improves code maintainability and focuses on the current testing approach.
…n Runner class - Added a check in the Runner class to raise a UserError when both a session and a list input are provided, clarifying the expected input format. - Introduced a new test in test_session.py to ensure that this validation works correctly across different runner methods.
- Added `SessionABC` as an abstract base class for session implementations, providing a clear structure for managing conversation history. - Defined abstract methods for message retrieval, addition, and session management, ensuring consistency across implementations. - Updated `SQLiteSession` to inherit from `SessionABC`, aligning with the new architecture.
Resolved conflicts in src/agents/run.py: - Kept both UserError and RunErrorDetails imports - Preserved session functionality (_prepare_input_with_session and _save_result_to_session) - Integrated upstream's RunErrorDetails exception handling - Maintained max turns check logic while incorporating upstream changes
I made it so using a session with list input raises an exception. There's a test to verify the exception gets raised. |
Overview
This PR introduces Sessions, a new core feature addressing issue #745 that automatically maintains conversation history across multiple agent runs, eliminating the need to manually handle
.to_input_list()
between turns.Key Features
🧠 Automatic Memory Management
Runner.run()
,Runner.run_sync()
, andRunner.run_streamed()
methods🔌 Extensible Session Protocol
💾 Built-in SQLite Implementation
🔧 Simple API
What's Included
Core Session Protocol
Session
Protocol: Clean, async interface that any storage backend can implementget_messages()
,add_messages()
,pop_message()
,clear_session()
Reference Implementation
SQLiteSession
Class: Production-ready SQLite implementationRunner Integration
session
parameter: Drop-in addition to existingRunner
methodsSession Protocol for Library Authors
The Session protocol provides a clean interface for implementing custom storage backends:
Example Third-Party Implementations
Benefits
For Application Developers
.to_input_list()
managementFor Library Authors
For Applications
Usage Examples
Basic Usage with SQLiteSession
Multiple Sessions with Isolation
Persistent vs In-Memory Storage
Session Management Operations
Message Correction Pattern
Technical Details
Session Protocol Design
SQLiteSession Implementation
Breaking Changes
None. This is a purely additive feature that doesn't affect existing functionality.
Documentation
docs/index.md
to highlight Sessions as a key primitivedocs/sessions.md
with protocol implementation examplesdocs/running_agents.md
with automatic vs manual conversation managementdocs/ref/memory.md
Sessions represent a significant architectural improvement for building conversational AI applications with the Agents SDK. The extensible Session protocol enables the ecosystem to provide specialized storage backends while maintaining a consistent, simple API for application developers.